Fixes undefined variable references #14

conradkleinespel · 2016-09-22T14:41:18Z

Fixes some undefined variable references.

One instance is not yet fixed (marked TODO) because I am unfamiliar with the model system at the moment. Will fix soon ! 😃

You can use jshint to find out about that kind of stuff automatically. For instance:

npm install -g jshint
jshint controllers/

jgigault · 2016-09-22T15:54:53Z

controllers/dashboard/routes.controller.js

@@ -129,6 +129,7 @@ function RoutesController(options) {
      }
    ], function(err, result) {
      if (err)
+        // TODO: this wont work, self is not defined
        return self.destroy(err);


This comes from another part of code.. It is a mistake, nothing to destroy here!

@jgigault Not sure what to do here. Can you make the appropriate change and merge ? I supposer the error err has to be handled somehow.

fixes undefined variables

67fe48d

jgigault reviewed Sep 22, 2016

View changes

fix error management

b9e2468

jgigault merged commit 1d0f774 into develop Sep 24, 2016
2 checks passed

jgigault deleted the conrad-fix-vars branch Sep 24, 2016

Fixes undefined variable references #14

Fixes undefined variable references #14

conradkleinespel commented Sep 22, 2016 •

edited

jgigault Sep 22, 2016

conradkleinespel Sep 22, 2016

Fixes undefined variable references #14

Fixes undefined variable references #14

Conversation

conradkleinespel commented Sep 22, 2016 • edited

jgigault Sep 22, 2016

Choose a reason for hiding this comment

conradkleinespel Sep 22, 2016

Choose a reason for hiding this comment

conradkleinespel commented Sep 22, 2016 •

edited