Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes undefined variable references #14

Merged
merged 2 commits into from Sep 24, 2016
Merged

Fixes undefined variable references #14

merged 2 commits into from Sep 24, 2016

Conversation

conradkleinespel
Copy link
Contributor

@conradkleinespel conradkleinespel commented Sep 22, 2016

Fixes some undefined variable references.

One instance is not yet fixed (marked TODO) because I am unfamiliar with the model system at the moment. Will fix soon ! 😃

You can use jshint to find out about that kind of stuff automatically. For instance:

npm install -g jshint
jshint controllers/

@@ -129,6 +129,7 @@ function RoutesController(options) {
}
], function(err, result) {
if (err)
// TODO: this wont work, self is not defined
return self.destroy(err);
Copy link
Member

@jgigault jgigault Sep 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes from another part of code.. It is a mistake, nothing to destroy here!

Copy link
Contributor Author

@conradkleinespel conradkleinespel Sep 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgigault Not sure what to do here. Can you make the appropriate change and merge ? I supposer the error err has to be handled somehow.

@jgigault jgigault merged commit 1d0f774 into develop Sep 24, 2016
2 checks passed
@jgigault jgigault deleted the conrad-fix-vars branch Sep 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants